Remove redundant logic to calculate the minimum number of partition b…

…efore creating new KMF topics (#341)
linkedin · Feb 11, 2021 · 7f99c09 · 7f99c09
1 parent 06178e6
commit 7f99c09
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/main/java/com/linkedin/xinfra/monitor/common/Utils.java b/src/main/java/com/linkedin/xinfra/monitor/common/Utils.java
@@ -169,7 +169,7 @@ public static int createTopicIfNotExists(String topic, short replicationFactor,
       throws ExecutionException, InterruptedException {
     try {
       if (adminClient.listTopics().names().get().contains(topic)) {
-        LOG.info("AdminClient indicates that {} already exists in the cluster. Topic config: {}", topic, topicConfig);
+        LOG.info("AdminClient indicates that topic {} already exists in the cluster. Topic config: {}", topic, topicConfig);
         return getPartitionNumForTopic(adminClient, topic);
       }
       int brokerCount = Utils.getBrokerCount(adminClient);

diff --git a/src/main/java/com/linkedin/xinfra/monitor/services/MultiClusterTopicManagementService.java b/src/main/java/com/linkedin/xinfra/monitor/services/MultiClusterTopicManagementService.java
@@ -310,9 +310,7 @@ void maybeCreateTopic() throws Exception {
                 "Refer to config: {}", _topic, _zkConnect, TopicManagementServiceConfig.TOPIC_CREATION_ENABLED_CONFIG);
         return;
       }
-      int brokerCount = _adminClient.describeCluster().nodes().get().size();
-      int numPartitions = Math.max((int) Math.ceil(brokerCount * _minPartitionsToBrokersRatio), minPartitionNum());
-      NewTopic newTopic = new NewTopic(_topic, numPartitions, (short) _replicationFactor);
+      NewTopic newTopic = new NewTopic(_topic, minPartitionNum(), (short) _replicationFactor);
       newTopic.configs((Map) _topicProperties);
       _topicFactory.createTopicIfNotExist(_topic, (short) _replicationFactor, _minPartitionsToBrokersRatio,
               _topicProperties, _adminClient);