Fix empty struct type in selectNot call #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pty-struct' into rzhang-fix-buildOrcProjection-empty-struct # Conflicts: # api/src/test/java/org/apache/iceberg/types/TestTypeUtil.java
|
@rzhang10 Can you file this upstream? Since this touches the API module, it will be helpful to not diverge from upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: we encounter dali2 spark exception reading a specific table, upon analysis, this table has a empty struct inside its schema, and this cause iceberg internally to not be able to construct the correct number of readers to match the fiedls, and thus throws a NPE. Upon debugging and analysis, the code that doesn't handle the empty struct correctly is in GetProjectedIds.java via TypeUtil.getIdsInternal call.
Tested the table with the empty struct schema using spark-shell, the table could now be read without exception.