[Coral-Trino] Use CoralSqlDialect during CoralRelNode to CoralSqlNode conversion #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmoustafa
approved these changes
Jul 31, 2024
KevinGe00
added a commit
to KevinGe00/coral
that referenced
this pull request
Jul 31, 2024
… conversion (linkedin#521) * temp * temp * use coralsqldialect in trino reltosql * Import class not member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
As part of the new Coral IR, we want all language-specific transformations to exist in the SqlNode layer, meaning we have to replace
TrinoSqlDialectused during the RelNode -> SqlNode phase of Coral-Trino's right hand side translation withCoralSqlDialect(theSqlDialectto represent Coral IR). This is only possible now after PRs such as #450 and #460, which madeTrinoSqlDialecta superset ofCoralSqlDialectwith no conflicting diffs.Note that
TrinoSqlDialectstill exists and is used at the final stage of Coral-Trino's right hand side. This is fine as it is language-specific transformations existing in the SqlNode layer.How was this patch tested?
clean build
regression tested