[CORAL-LOG] Improve Artifacts Resolver Log.

linkedin · Feb 4, 2024 · a3cddec · a3cddec
1 parent e08a039
commit a3cddec
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/coral-hive/src/main/java/com/linkedin/coral/hive/hive2rel/functions/ArtifactsResolver.java b/coral-hive/src/main/java/com/linkedin/coral/hive/hive2rel/functions/ArtifactsResolver.java
@@ -128,8 +128,8 @@ private ResolveReport getDependencies(String udfClassName, DependencySpec depend
     try {
       final ResolveReport report = _ivyInstance.resolve(md, resolveOptions);
       if (report.hasError()) {
-        LOG.warn(
-            String.format("Unable to fetch dependencies for UDF %s: %s", udfClassName, report.getAllProblemMessages()));
+        LOG.warn("Unable to fetch dependencies for UDF {}: {}",
+            udfClassName, report.getAllProblemMessages());
       }
       return report;
     } catch (ParseException | IOException e) {
@@ -142,11 +142,11 @@ private static IvySettings setupIvySettings() {
     try {
       if (System.getenv().containsKey(IVY_SETTINGS_LOCATION)) {
         File settingsFile = getSettingsFile();
-        LOG.info("Reading Ivy settings from: " + settingsFile);
+        LOG.info("Reading Ivy settings from: {}.", settingsFile);
         settings.load(settingsFile);
       } else {
         final URL settingsUrl = ArtifactsResolver.class.getClassLoader().getResource(IVY_SETTINGS_FILE_NAME);
-        LOG.info("Reading Ivy settings from: " + settingsUrl);
+        LOG.info("Reading Ivy settings from: {}.", settingsUrl);
         settings.load(settingsUrl);
       }
     } catch (ParseException | IOException e) {
@@ -202,7 +202,7 @@ private static int getIvyLogLevel() {
     try {
       return Integer.parseInt(r);
     } catch (NumberFormatException ignore) {
-      LOG.warn("Could not parse number: " + r + " corresponding to key: " + IVY_LOG_LEVEL);
+      LOG.warn("Could not parse number: {} corresponding to key: {}.", r, IVY_LOG_LEVEL);
       return Message.MSG_INFO;
     }
   }