[fast-avro] Added a few serde optimization #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixGV
reviewed
Sep 20, 2023
...sts-common/src/test/java/com/linkedin/avro/fastserde/FastGenericSerializerGeneratorTest.java
Outdated
Show resolved
Hide resolved
...avro-fastserde/src/main/java/com/linkedin/avro/fastserde/BufferBackedPrimitiveFloatList.java
Outdated
Show resolved
Hide resolved
...ro-fastserde/src/main/java11/com/linkedin/avro/fastserde/BufferBackedPrimitiveFloatList.java
Outdated
Show resolved
Hide resolved
...ro-fastserde/src/main/java11/com/linkedin/avro/fastserde/BufferBackedPrimitiveFloatList.java
Show resolved
Hide resolved
|
Should we wait until we finish benchmarking deserialization path? |
Why wait? We can always submit another PR if we discover other opportunities, right? |
Serializer: This code change will try to reuse the backed bytes if the float list is 'BufferBackedPrimitiveFloatList' when writing float list. If an instance of `BufferBackedPrimitiveFloatList` is changed after deserialization: `readPrimitiveFloatArray`, Fast Serializer won't use the backed bytes because of the divergence. Deserializer: Use `reset` instead of `clear` when reusing `GenericArray` since `reset` is cheaper than `clear` and the behavior difference is that `reset` won't nullify the elements in current array, but just resize the array length to be 0.
gaojieliu
force-pushed
the
fast_avro_optimization
branch
from
aa05e8f
to
1f3c648
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #517 +/- ##
============================================
+ Coverage 45.77% 45.78% +0.01%
- Complexity 4438 4442 +4
============================================
Files 403 403
Lines 28070 28070
Branches 4622 4622
============================================
+ Hits 12850 12853 +3
Misses 13664 13664
+ Partials 1556 1553 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serializer:
This code change will try to reuse the backed bytes if the float list is 'BufferBackedPrimitiveFloatList' when writing float list. If an instance of
BufferBackedPrimitiveFloatListis changed after deserialization:readPrimitiveFloatArray, Fast Serializer won't use the backed bytes because of the divergence.Deserializer:
Use
resetinstead ofclearwhen reusingGenericArraysinceresetis cheaper thanclearand the behavior difference is thatresetwon't nullify the elements in current array, but just resize the array length to be 0.