[fastserde] Fix issue with generating schema fingerprint when NaN is default value. #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when default value is NaN.
krisso-rtb
force-pushed
the
bugfix/NaN-as-default
branch
from
1cea078
to
921dcb1
Compare
FelixGV
reviewed
Aug 29, 2023
Comment on lines
-220
to
+219
| if (!isAMathematicalInteger(numericValue)) { | ||
| if (!isAMathematicalInteger(defaultValue.getDecimalValue())) { |
There was a problem hiding this comment.
Is this the fix? I don't understand... isn't the code equivalent?
There was a problem hiding this comment.
If defaultType is DOUBLE or FLOAT and genericDefaultValue represents NaN then calling genericDefaultValue.decimalValue() is
- not needed
- throws
NumberFormatException
In other words it's called too early.
There was a problem hiding this comment.
Oooh I see. Ok, cool. Thanks for explaining, good catch.
FelixGV
approved these changes
Aug 30, 2023
Comment on lines
-220
to
+219
| if (!isAMathematicalInteger(numericValue)) { | ||
| if (!isAMathematicalInteger(defaultValue.getDecimalValue())) { |
There was a problem hiding this comment.
Oooh I see. Ok, cool. Thanks for explaining, good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.