Codegen : Custom decode method broken into subMethods #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg-builder
approved these changes
Aug 16, 2023
| "this." + replaceSingleDollarSignWithDouble(escapedFieldName), StringUtils.EMPTY_STRING)); | ||
|
|
||
| while (fieldCounter < recordSchema.getFields().size()) { | ||
| String chunkMethodName = "customDecodeIfChunk" + chunkCounter; |
There was a problem hiding this comment.
nit - why call the method "customDecodeIfChunk0()" ?
as oposed to customDecodeChunk0() ? what does the "if" stand for?
There was a problem hiding this comment.
The generated method has if and else chunks.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
============================================
+ Coverage 45.75% 45.83% +0.08%
- Complexity 4432 4440 +8
============================================
Files 398 398
Lines 28015 28041 +26
Branches 4619 4621 +2
============================================
+ Hits 12817 12852 +35
+ Misses 13640 13635 -5
+ Partials 1558 1554 -4
☔ View full report in Codecov by Sentry. |
flowenol
pushed a commit
to RTBHOUSE/avro-util
that referenced
this pull request
Aug 23, 2023
* breaking custom decode into sub methods * updated block size of customDecode blocks to 25 * 1000 field record round-trip ser/deser UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This change will break up generated customDecode method into small subMethods while keeping the functionality consistent.
Why
Since generated customDecode method can be large for larger schemas, it could exceed size limit 64k. Splitting method into smaller subMethods avoids it.
Issue: #257
Test
Added UT with a 1000 field record round trip ser/deserialization.
Errors out on current master