Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class generation for nested map field #504

Closed
wants to merge 1 commit into from

Conversation

nisargthakkar
Copy link
Contributor

Records for schemas with nested maps fail to be when deserialized with fastserde. This PR adds a test case (FastNestedMapTest.java) to validate behavior

@@ -97,7 +97,7 @@ protected ListIterator<Symbol> actionIterator(FieldAction action) {
while (actionIterator.hasNext()) {
Symbol symbol = actionIterator.next();

if(Symbol.Kind.REPEATER.equals(symbol.kind) && "array-end".equals(((Symbol.Repeater)symbol).end.toString())) {
if(Symbol.Kind.REPEATER.equals(symbol.kind)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not really needed, but I feel it should include map-end too. Let me know if you'd like me to remove this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant