xilem_web: Add a few boolean attribute modifiers for HtmlInputElement and factor element state flags out of these modifiers into ElementFlags
#717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anages general element flags (was_created/in_hydration etc.), to avoid duplicating this state in every modifier.
Philipp-M
commented
Oct 26, 2024
Philipp-M
force-pushed
the
xilem_web-input-element-modifiers
branch
from
14ed3b2 to
fe23251
Compare
RagibHasin
reviewed
Oct 27, 2024
xilem_web/src/interfaces.rs
Outdated
Comment on lines
825
to
838
| /// See <https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/multiple> for more details. | ||
| /// | ||
| /// # Examples | ||
| /// | ||
| /// ``` | ||
| /// use xilem_web::{interfaces::{Element, HtmlInputElement}, elements::html::input}; | ||
| /// | ||
| /// # fn component() -> impl HtmlInputElement<()> { | ||
| /// input(()).required(true) // results in <input required></input> | ||
| /// # } | ||
| /// ``` | ||
| fn multiple(self, required: bool) -> html_input_element::view::Multiple<Self, State, Action> { | ||
| html_input_element::view::Multiple::new(self, required) | ||
| } |
There was a problem hiding this comment.
I think it is a copy-paste artifact. That is the parameter should be named multiple as well and the doc is wrong.
There was a problem hiding this comment.
Thanks for catching this, I went over the rest of the doc-comments and have found a few inconsistencies as well.
I hope I have now found and fixed all...
I've also renamed With to WithModifier as it seems more appropriate, and it's likely summed up in these alias traits anyway.
There was a problem hiding this comment.
I've also renamed
WithtoWithModifieras it seems more appropriate
👍 It looks like a small change, but from my point of view it is enormously helpful for readability! 👍
flosse
approved these changes
Oct 28, 2024
RagibHasin
requested changes
Oct 28, 2024
RagibHasin
approved these changes
Oct 28, 2024
|
Thanks for the reviews :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts with supporting specialized elements (i.e. more than just the
ElementDOM interface), starting with boolean attributes inHtmlInputElement(checked,default_checked,disabled,required,multiple).With a general
OverwriteBoolmodifier which is optimized by encoding boolean flags into au32, thus not requiring allocations (compared to the other modifiers we currently have), but is limited to max 32 overwrites, which I don't think should be a real-world limitation (i.e.input_el.checked().checked()...checked()32 times makes no sense), I also started adding tests for this, as it juggles around with bit-operations (and we should generally start writing more tests).I have originally planned to feature-flag this (i.e. have a feature like
HtmlInputElement).But I'd like to see how far we can go without this, I haven't yet noticed significant (binary-size) regressions in the todomvc example (which uses
inputelements) that justifies the worse DX that additional features introduce.Having features for this is also not optimal for another reason: It changes the API (e.g.
DomNode::Propsisprops::HtmlInputElementinstead ofprops::Element.It also factors the element state flags (
was_created,in_hydration) into a separateElementFlagswhich is shared within aModifier<M>struct (similar asPodMutorWidgetMutin masonry), so that we don't have to duplicate that state in every modifier. Additionally a new flagneeds_updateis introduced, which indicates that the element in general needs to update any modifier, and is entirely an optimization to avoid checking every modifier whether it has changed (not yet that important, but when we have a lot of modifiers per element, having to check every modifier is less efficient, it's also already slightly visible in the js-framework-benchmark).For this, it unfortunately suffers similar as #705 from the free-form syntax by being a little bit more verbose (which may be reverted after
arbitrary_self_typesare stable).It should also fix #716