Fix kurbo::BezPath d attribute for xilem_web::svg::path element #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xorgy
approved these changes
Oct 25, 2024
xorgy
previously requested changes
Oct 25, 2024
|
Whoops, not sure how that did happen... Nice catch, I thought I tested this, but this is the only kurbo view that's not in the svgtoy example... Bad luck... |
|
Should we have an example which uses this? |
|
I wanted to add the stroke expansion demo in here as example, that would include this as well, we can of course also extend the (somewhat catch-all) svgtoy example. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 9, 2024
Add a simple example showing, that svg nodes can also be used similarly as a `CanvasRenderingContext2D` to draw some lines. This takes advantage of a `kurbo::QuadSpline` to avoid sharp edges when the pointer moves fast. See [this](https://xi.zulipchat.com/#narrow/channel/354396-xilem/topic/web.3A.20Canvas.20options.20set.20with.20.60after_build.60.20doesn't.20persist) zulip topic for more context. This could potentially be optimized further (don't clone/recalculate all the lines every reconciliation), but I think in its current state it's also a good test to see how a naive implementation performs, and so far it's not too bad. Btw. as noted [here](#715 (comment)) this implicitly also adds the `BezPath` as the example (for more manual testing opportunities).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed in #699
cc @Philipp-M 🦆