Add support for `impl View for Arc/Rc<impl View>` #164

Philipp-M · 2024-01-22T22:35:30Z

No description provided.

crates/xilem_core/src/view/rc.rs

crates/xilem_web/src/view.rs

jaredoconnell · 2024-01-23T16:08:14Z

Now, or later when the examples are improved, this would definitely benefit from a brief example.

Philipp-M · 2024-01-23T16:30:33Z

Now, or later when the examples are improved, this would definitely benefit from a brief example.

You're right, I could add one here, that shows a use-case for this (it's an alternative to Memoize)

Philipp-M · 2024-01-23T18:20:43Z

Good idea to mention the example, I've implemented it via an example for memoization and quite a few views were not yet exported... It also revealed a bomb:

View needs to be Sync to support Arc<impl View>.

I think if we want to store shared views in general in the app state this requirement will come sooner or later (e.g. by supporting a rope of views as a ViewSequence).

…g parentheses

crates/xilem_core/src/view/rc.rs

Co-authored-by: Jonas Platte <[email protected]>

…d to be `Sync`

Philipp-M · 2024-01-24T17:46:06Z

Ok, at least for View::State, Sync bounds are not necessary. I've relaxed this via adjustments in the macros.

jplatte · 2024-01-24T18:52:16Z

crates/xilem_core/src/any_view.rs

@@ -3,22 +3,22 @@

 #[macro_export]
 macro_rules! generate_anyview_trait {
-    ($anyview:ident, $viewtrait:ident, $viewmarker:ty, $cx:ty, $changeflags:ty, $anywidget:ident, $boxedview:ident; $($ss:tt)*) => {
+    ($anyview:ident, $viewtrait:ident, $viewmarker:ty, $cx:ty, $changeflags:ty, $anywidget:ident, $boxedview:ident; ($($super_bounds:tt)*), ($($state_bounds:tt)*)) => {


I was going to suggest changing the input to avoid the parentheses here too, but unfortunately that runs into rust-lang/rust#18700 (last comment has a workaround, but probably not worth using that here).

Maybe make the last two parameters optional using $()? though? The invocation with (), () looks weird.

Yes I think it's difficult to get rid of () in general (while covering everything that is allowed in trait bounds).

I've used optionals as you said

crates/xilem_core/src/any_view.rs

crates/xilem_core/src/view/mod.rs

…w` to `AnyView`

Philipp-M · 2024-01-25T16:02:55Z

I have added impl View for Arc<dyn AnyView> as well (resolves the TODO in the example and makes everything a little bit cleaner).

Philipp-M · 2024-01-25T16:04:05Z

I've added the super bounds of View to AnyView as well, to avoid Box<dyn AnyView + Send + Sync>

… of it

Philipp-M · 2024-03-13T22:17:43Z

Whoops, I was a little bit too eager with deleting old branches...

This ports the `Memoize` view from old xilem, slightly enhances it, by checking whether the given view callback is a non-capturing closure and not a function pointer (by asserting `std::mem::size_of::<F>() == 0`) It also ports the `Arc<impl View>` and `Arc<dyn AnyMasonryView>` from linebender#164 including the example there to show how these two forms of memoization can be used.

This ports the `Memoize` view from old xilem, slightly enhances it, by checking whether the given view callback is a non-capturing closure and not a function pointer (by asserting `std::mem::size_of::<F>() == 0`) It also ports the `Arc<impl View>` and `Arc<dyn AnyMasonryView>` from #164 including the example there to show how these two forms of memoization can be used.

DJMcNab · 2024-06-06T12:34:44Z

I think this can be closed - this is included in #310

Philipp-M · 2024-06-06T13:53:41Z

Yes it can be closed

New tracy image: ![image](https://github.com/user-attachments/assets/94e54c89-8159-4dd4-a521-4a7122f64375) New log tracing file: <details><summary>An overview of the new logs</summary> <p> ``` 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}: masonry::passes::update: RootWidget received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}: masonry::passes::update: Flex received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#8}: masonry::passes::update: Flex received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#8}:SizedBox{id=#7}: masonry::passes::update: SizedBox received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#8}:SizedBox{id=#7}:Flex{id=#6}: masonry::passes::update: Flex received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#8}:SizedBox{id=#7}:Flex{id=#6}:Flex{id=#3}: masonry::passes::update: Flex received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#8}:SizedBox{id=#7}:Flex{id=#6}:Flex{id=#3}:Prose{id=#1}: masonry::passes::update: Prose received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#8}:SizedBox{id=#7}:Flex{id=#6}:Flex{id=#3}:Label{id=#2}: masonry::passes::update: Label received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#8}:SizedBox{id=#7}:Flex{id=#6}:Flex{id=#5}: masonry::passes::update: Flex received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#8}:SizedBox{id=#7}:Flex{id=#6}:Flex{id=#5}:VariableLabel{id=#4}: masonry::passes::update: VariableLabel received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#17}: masonry::passes::update: Flex received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#17}:Button{id=#10}: masonry::passes::update: Button received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#17}:Button{id=#10}:Label{id=#9}: masonry::passes::update: Label received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#17}:Button{id=#12}: masonry::passes::update: Button received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#17}:Button{id=#12}:Label{id=#11}: masonry::passes::update: Label received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#17}:Button{id=#14}: masonry::passes::update: Button received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#17}:Button{id=#14}:Label{id=#13}: masonry::passes::update: Label received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#17}:Button{id=#16}: masonry::passes::update: Button received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Flex{id=#17}:Button{id=#16}:Label{id=#15}: masonry::passes::update: Label received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Portal{id=#163}: masonry::passes::update: Portal received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Portal{id=#163}:Flex{id=#160}: masonry::passes::update: Flex received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Portal{id=#163}:Flex{id=#160}:SizedBox{id=#24}: masonry::passes::update: SizedBox received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Portal{id=#163}:Flex{id=#160}:SizedBox{id=#24}:Flex{id=#23}: masonry::passes::update: Flex received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Portal{id=#163}:Flex{id=#160}:SizedBox{id=#24}:Flex{id=#23}:Flex{id=#20}: masonry::passes::update: Flex received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Portal{id=#163}:Flex{id=#160}:SizedBox{id=#24}:Flex{id=#23}:Flex{id=#20}:Prose{id=#18}: masonry::passes::update: Prose received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Portal{id=#163}:Flex{id=#160}:SizedBox{id=#24}:Flex{id=#23}:Flex{id=#20}:Label{id=#19}: masonry::passes::update: Label received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Portal{id=#163}:Flex{id=#160}:SizedBox{id=#24}:Flex{id=#23}:Flex{id=#22}: masonry::passes::update: Flex received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Portal{id=#163}:Flex{id=#160}:SizedBox{id=#24}:Flex{id=#23}:Flex{id=#22}:VariableLabel{id=#21}: masonry::passes::update: VariableLabel received Update::WidgetAdded 14:37:40.365Z TRACE update_new_widgets:RootWidget{id=#165}:Flex{id=#164}:Portal{id=#163}:Flex{id=#160}:SizedBox{id=#31}: masonry::passes::update: SizedBox received Update::WidgetAdded ``` </p> </details> This was originally an experiment into caching spans, but I determined that was non-viable due to the pass names.

Add support for impl View for Arc/Rc<impl View>

1a6c45a

jplatte reviewed Jan 23, 2024

View reviewed changes

crates/xilem_core/src/view/rc.rs Outdated Show resolved Hide resolved

crates/xilem_web/src/view.rs Outdated Show resolved Hide resolved

Be consistent with braces

acb3596

Added example for memoization

7ff11fa

Improve syntax of the parameters of generate_rc_view macro by removin…

a9f9089

…g parentheses

jplatte reviewed Jan 23, 2024

View reviewed changes

crates/xilem_core/src/view/rc.rs Outdated Show resolved Hide resolved

crates/xilem_core/src/view/rc.rs Outdated Show resolved Hide resolved

crates/xilem_core/src/view/rc.rs Outdated Show resolved Hide resolved

Philipp-M and others added 2 commits January 23, 2024 22:32

Postfix :: instead of prefix

6d69019

Co-authored-by: Jonas Platte <[email protected]>

Separate super and state bounds for view macros, as state doesn't nee…

e1e9f78

…d to be `Sync`

jplatte reviewed Jan 24, 2024

View reviewed changes

Philipp-M added 2 commits January 24, 2024 20:59

Beautify parameter syntax of the macros via optionals for the bounds

f2216c2

Implement View for Arc<dyn AnyView>, and add super bounds of `Vie…

12dc722

…w` to `AnyView`

Philipp-M added a commit to Philipp-M/xilem that referenced this pull request Jan 25, 2024

Add macro beatifications of linebender#164 and adjust the invocations…

01c393a

… of it

Philipp-M added a commit to Philipp-M/xilem that referenced this pull request Feb 12, 2024

Add macro beatifications of linebender#164 and adjust the invocations…

beac30a

… of it

Philipp-M added a commit to Philipp-M/xilem that referenced this pull request Feb 15, 2024

Add macro beatifications of linebender#164 and adjust the invocations…

fd66a4c

… of it

Merge branch 'main' into arc-view

b85d8ad

Philipp-M closed this Mar 13, 2024

Philipp-M deleted the arc-view branch March 13, 2024 22:16

Philipp-M restored the arc-view branch March 13, 2024 22:16

Philipp-M reopened this Mar 13, 2024

Fix clippy lints

9413b63

Philipp-M mentioned this pull request May 5, 2024

xilem: Add Memoization views (Memoize and Arc<impl View>) #267

Merged

Philipp-M closed this Jun 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for `impl View for Arc/Rc<impl View>` #164

Add support for `impl View for Arc/Rc<impl View>` #164

Philipp-M commented Jan 22, 2024

jaredoconnell commented Jan 23, 2024

Philipp-M commented Jan 23, 2024

Philipp-M commented Jan 23, 2024

Philipp-M commented Jan 24, 2024

jplatte Jan 24, 2024

jplatte Jan 24, 2024

Philipp-M Jan 24, 2024

Philipp-M Jan 24, 2024

Philipp-M commented Jan 25, 2024

Philipp-M commented Jan 25, 2024

Philipp-M commented Mar 13, 2024

DJMcNab commented Jun 6, 2024

Philipp-M commented Jun 6, 2024

Add support for impl View for Arc/Rc<impl View> #164

Add support for impl View for Arc/Rc<impl View> #164

Conversation

Philipp-M commented Jan 22, 2024

jaredoconnell commented Jan 23, 2024

Philipp-M commented Jan 23, 2024

Philipp-M commented Jan 23, 2024

Philipp-M commented Jan 24, 2024

jplatte Jan 24, 2024

Choose a reason for hiding this comment

jplatte Jan 24, 2024

Choose a reason for hiding this comment

Philipp-M Jan 24, 2024

Choose a reason for hiding this comment

Philipp-M Jan 24, 2024

Choose a reason for hiding this comment

Philipp-M commented Jan 25, 2024

Philipp-M commented Jan 25, 2024

Philipp-M commented Mar 13, 2024

DJMcNab commented Jun 6, 2024

Philipp-M commented Jun 6, 2024

Add support for `impl View for Arc/Rc<impl View>` #164

Add support for `impl View for Arc/Rc<impl View>` #164