Generalize VecSplice that is used in the ViewSequences as ElementsSplice trait and optimize tree-structure diffing in xilem_web with it
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Splice` trait and optimized tree-structure diffing in `xilem_web` with it
|
Closing as this will be merged with/as #160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly changes the
ViewSequencetrait to take a traitdyn ElementsSpliceinstead of theVecSplice. Functionally (in xilem) this should result in the same. But it has the advantage to track diffing more precisely inViewSequences.This is used in
xilem_webto only update elements that actually have changed (instead of removing all elements and adding the rebuilt elements again).