xilem_html: Significant refactor and introduce DOM interface traits

Cargo.toml

@@ -3,7 +3,7 @@ members = [
     "crates/xilem_core",
     "crates/xilem_html",
     "crates/xilem_html/web_examples/counter",
-    "crates/xilem_html/web_examples/counter_untyped",
+    "crates/xilem_html/web_examples/counter_custom_element",
     "crates/xilem_html/web_examples/todomvc",
     "crates/xilem_svg",
     "crates/xilem_svg/web_examples/svgtoy",

crates/xilem_html/Cargo.toml

@@ -17,36 +17,12 @@ default-target = "x86_64-pc-windows-msvc"
 # rustdoc-scrape-examples tracking issue https://github.com/rust-lang/rust/issues/88791
 cargo-args = ["-Zunstable-options", "-Zrustdoc-scrape-examples"]
 
-[features]
-default = ["typed"]
-typed = [
-    "web-sys/FocusEvent", "web-sys/HtmlAnchorElement", "web-sys/HtmlAreaElement",
-    "web-sys/HtmlAudioElement", "web-sys/HtmlBrElement", "web-sys/HtmlButtonElement",
-    "web-sys/HtmlCanvasElement", "web-sys/HtmlDataElement", "web-sys/HtmlDataListElement",
-    "web-sys/HtmlDetailsElement", "web-sys/HtmlDialogElement", "web-sys/HtmlDivElement",
-    "web-sys/HtmlDListElement", "web-sys/HtmlEmbedElement", "web-sys/HtmlFieldSetElement",
-    "web-sys/HtmlFormElement", "web-sys/HtmlHeadingElement", "web-sys/HtmlHrElement",
-    "web-sys/HtmlIFrameElement", "web-sys/HtmlImageElement", "web-sys/HtmlInputElement",
-    "web-sys/HtmlLabelElement", "web-sys/HtmlLegendElement", "web-sys/HtmlLiElement",
-    "web-sys/HtmlMapElement", "web-sys/HtmlMenuElement", "web-sys/HtmlMeterElement",
-    "web-sys/HtmlModElement", "web-sys/HtmlObjectElement", "web-sys/HtmlOListElement",
-    "web-sys/HtmlOptGroupElement", "web-sys/HtmlOptionElement", "web-sys/HtmlOutputElement",
-    "web-sys/HtmlParagraphElement", "web-sys/HtmlPictureElement", "web-sys/HtmlPreElement",
-    "web-sys/HtmlProgressElement", "web-sys/HtmlQuoteElement", "web-sys/HtmlScriptElement",
-    "web-sys/HtmlSelectElement", "web-sys/HtmlSlotElement", "web-sys/HtmlSourceElement",
-    "web-sys/HtmlSpanElement", "web-sys/HtmlTableElement", "web-sys/HtmlTableCellElement",
-    "web-sys/HtmlTableColElement", "web-sys/HtmlTableCaptionElement", "web-sys/HtmlTableRowElement",
-    "web-sys/HtmlTableSectionElement", "web-sys/HtmlTemplateElement", "web-sys/HtmlTextAreaElement",
-    "web-sys/HtmlTimeElement", "web-sys/HtmlTrackElement", "web-sys/HtmlUListElement",
-    "web-sys/HtmlVideoElement", "web-sys/InputEvent", "web-sys/KeyboardEvent", "web-sys/MouseEvent",
-    "web-sys/PointerEvent", "web-sys/WheelEvent",
-]
-
 [dependencies]
 xilem_core.workspace = true
 kurbo.workspace = true
 bitflags = "2"
 wasm-bindgen = "0.2.87"
+paste = "1"
 log = "0.4.19"
 gloo = { version = "0.8.1", default-features = false, features = ["events", "utils"] }
 
@@ -63,4 +39,67 @@ features = [
     "SvgElement",
     "Text",
     "Window",
+    "FocusEvent",
+    "HtmlInputElement",
+    "InputEvent",
+    "KeyboardEvent",
+    "MouseEvent",
+    "PointerEvent",
+    "WheelEvent",
+    "HtmlAnchorElement",
+    "HtmlAreaElement",
+    "HtmlAudioElement",
+    "HtmlBrElement",
+    "HtmlButtonElement",
+    "HtmlCanvasElement",
+    "HtmlDataElement",
+    "HtmlDataListElement",
+    "HtmlDetailsElement",
+    "HtmlDialogElement",
+    "HtmlDivElement",
+    "HtmlDListElement",
+    "HtmlEmbedElement",
+    "HtmlFieldSetElement",
+    "HtmlFormElement",
+    "HtmlHeadingElement",
+    "HtmlHrElement",
+    "HtmlIFrameElement",
+    "HtmlImageElement",
+    "HtmlInputElement",
+    "HtmlLabelElement",
+    "HtmlLegendElement",
+    "HtmlLiElement",
+    "HtmlLinkElement",
+    "HtmlMapElement",
+    "HtmlMediaElement",
+    "HtmlMenuElement",
+    "HtmlMeterElement",
+    "HtmlModElement",
+    "HtmlObjectElement",
+    "HtmlOListElement",
+    "HtmlOptGroupElement",
+    "HtmlOptionElement",
+    "HtmlOutputElement",
+    "HtmlParagraphElement",
+    "HtmlPictureElement",
+    "HtmlPreElement",
+    "HtmlProgressElement",
+    "HtmlQuoteElement",
+    "HtmlScriptElement",
+    "HtmlSelectElement",
+    "HtmlSlotElement",
+    "HtmlSourceElement",
+    "HtmlSpanElement",
+    "HtmlTableCaptionElement",
+    "HtmlTableCellElement",
+    "HtmlTableColElement",
+    "HtmlTableElement",
+    "HtmlTableRowElement",
+    "HtmlTableSectionElement",
+    "HtmlTemplateElement",
+    "HtmlTimeElement",
+    "HtmlTextAreaElement",
+    "HtmlTrackElement",
+    "HtmlUListElement",
+    "HtmlVideoElement",
 ]

crates/xilem_html/src/attribute.rs

@@ -0,0 +1,52 @@
+use std::borrow::Cow;
+use std::marker::PhantomData;
+
+use xilem_core::{Id, MessageResult};
+
+use crate::{interfaces::sealed::Sealed, AttributeValue, ChangeFlags, Cx, View, ViewMarker};
+
+use super::interfaces::Element;
+
+pub struct Attr<T, A, E> {
+    pub(crate) element: E,
+    pub(crate) name: Cow<'static, str>,
+    pub(crate) value: Option<AttributeValue>,
+    pub(crate) phantom: PhantomData<fn() -> (T, A)>,
+}
+
+impl<T, A, E> ViewMarker for Attr<T, A, E> {}
+impl<T, A, E> Sealed for Attr<T, A, E> {}
+
+impl<T, A, E: Element<T, A>> View<T, A> for Attr<T, A, E> {
+    type State = E::State;
+    type Element = E::Element;
+
+    fn build(&self, cx: &mut Cx) -> (Id, Self::State, Self::Element) {
+        cx.add_new_attribute_to_current_element(&self.name, &self.value);
+        self.element.build(cx)
+    }
+
+    fn rebuild(
+        &self,
+        cx: &mut Cx,
+        prev: &Self,
+        id: &mut Id,
+        state: &mut Self::State,
+        element: &mut Self::Element,
+    ) -> ChangeFlags {
+        cx.add_new_attribute_to_current_element(&self.name, &self.value);
+        self.element.rebuild(cx, &prev.element, id, state, element)
+    }
+
+    fn message(
+        &self,
+        id_path: &[Id],
+        state: &mut Self::State,
+        message: Box<dyn std::any::Any>,
+        app_state: &mut T,
+    ) -> MessageResult<A> {
+        self.element.message(id_path, state, message, app_state)
+    }
+}
+
+crate::interfaces::impl_dom_interfaces_for_ty!(Element, Attr);

crates/xilem_html/src/element/attribute_value.rs → crates/xilem_html/src/attribute_value.rs

@@ -1,6 +1,6 @@
 type CowStr = std::borrow::Cow<'static, str>;
 
-#[derive(PartialEq, Debug)]
+#[derive(PartialEq, Clone, Debug, PartialOrd)]
 pub enum AttributeValue {
     True, // for the boolean true, this serializes to an empty string (e.g. for <input checked>)
     I32(i32),