Dust off xilem_svg #139
Merged
Dust off xilem_svg #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having the demo app hardcoded, make it a library with a web_examples folder, just like its xilem_html sibling. This patch doesn't change the example or any functionality.
Exports a `ViewExt` trait, and wires up types so that type inference can flow through the methods on this trait. That removes the hacky `KurboShape` workaround.
Supports very basic fill and stroke (solid colors, stroke width but no other style parameters).
|
I think the readme of |
|
Agree on the readme change. In fact, I did a small update but it seems like that got lost (probably a |
Philipp-M
reviewed
Nov 4, 2023
Philipp-M
reviewed
Nov 4, 2023
Fix some cut'n'paste errors, and update README slightly.
Philipp-M
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the xilem_svg crate to make it suitable for tinkering. The demo app is moved to a separate crate, rather than being hardwired, and the
ViewExttrait is wired up properly (replacing the previousKurboShapehack).