xilem_html: Experiment with composition types and strong typed DOM elements #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed with a `CustomElement` View
* Remove old element views and events * Repurpose `counter_untyped` example to `counter_custom_element` * Make typing the sensible default (but DOM interfaces will be able to be toggled via feature flags in the future) * Make the `EventTarget` trait a View, so that every DOM interface, including Node has to be a `View` (whether this makes sense for `EventTarget` is an open question)
…ilder pattern for EventListener options
|
Closing in favor of #141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of the "opposite" approach compared to #119 by using types for all kinds of attributes.
Checkout this zulip thread for more information of all the findings while experimenting with this (and #119).