-
Notifications
You must be signed in to change notification settings - Fork 120
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tree_arena: Use
hashbrown::HashMap
as drop-in replacement to optimi…
…ze tree-access (#774) As noted in #772 (review), this seems to be a really cheap but quite effective optimization, as we have `hashbrown` already in our dependency tree. I've noticed speedups of the rewrite passes of up to >100%. On average about 20-50% and is also definitely noticeable (smoother and less latency). Another quite interesting observation with my (admittedly not really reproducible) performance tests, is that the safe tree arena is actually faster than the unsafe version (roughly 10-30%), and tells yet another time that benches are really important while optimizing... Rough overview of my performance tests/benches: I've mostly hovered over 10000 buttons in the mason example while testing, but every second or so a new button is spawned and also this is quite a bit faster. I did a quick'n dirty `Instant::elapsed` in the event loop (so rendering is not included, but I think there's also a speedup as we're iterating the tree).
- Loading branch information
Showing
5 changed files
with
8 additions
and
2 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters