Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DrawColor endianness docs #796

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Fix DrawColor endianness docs #796

merged 2 commits into from
Jan 20, 2025

Conversation

tomcur
Copy link
Member

@tomcur tomcur commented Jan 19, 2025

This was missed when Color switched to packing as little-endian.

This was missed when Color switched to packing as little-endian.
@tomcur
Copy link
Member Author

tomcur commented Jan 19, 2025

I've added the change to vello_encoding::DrawColor to the changelog as breaking, under the assumption that's tracked.

@tomcur tomcur added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 032d893 Jan 20, 2025
17 checks passed
@tomcur tomcur deleted the endian branch January 20, 2025 08:18
tomcur added a commit that referenced this pull request Jan 21, 2025
`DrawColor` docs got out of sync (see
#796), and could get out of sync
again: the code doing the packing and the code reading it do not live
in this file.

Test whether it is premultiplied for good measure.
github-merge-queue bot pushed a commit that referenced this pull request Jan 21, 2025
`DrawColor` docs got out of sync (see
#796), and could get out of sync
again: the code doing the packing and the code reading it do not live in
this file.

Test whether it is premultiplied for good measure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants