Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match CPU/GPU logic for start tangents #705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Match CPU/GPU logic for start tangents #705

wants to merge 1 commit into from
+44 −16

Commits on Sep 26, 2024

  1. Match CPU/GPU logic for start tangents 

    When encoding a start tangent for an end cap or closed segment, use
logic designed to match the GPU computed tangent for the first segment.

Note: this changes the GPU calculation to write out the lerp calculation
explicitly rather than use the mix intrinsic, so we can rely on the
rounding behavior. In the presence of fastmath, the rounding behavior is
not guaranteed, but it is verified to work on M1.

Fixes #704, unless we get bitten by fastmath.
    @raphlinus
    raphlinus committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a05c730 View commit details
    Browse the repository at this point in the history