Skip to content

Commit

Permalink
address comment by @ikhoon
Browse files Browse the repository at this point in the history
  • Loading branch information
jrhee17 committed Aug 1, 2023
1 parent a728d4f commit 9e86a58
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -527,8 +527,7 @@ protected final Consumer<DnsNameResolverBuilder> buildConfigurator(EventLoopGrou
builder.queryTimeoutMillis(queryTimeoutMillisForEachAttempt);
} else {
if (queryTimeoutMillis == 0 || queryTimeoutMillis == Long.MAX_VALUE) {
// Use 0 to disable the timeout once https://github.com/netty/netty/pull/13505 is merged.
builder.queryTimeoutMillis(3600000); // 1 hour
builder.queryTimeoutMillis(0);

Check warning on line 530 in core/src/main/java/com/linecorp/armeria/client/AbstractDnsResolverBuilder.java

View check run for this annotation

Codecov / codecov/patch

core/src/main/java/com/linecorp/armeria/client/AbstractDnsResolverBuilder.java#L530

Added line #L530 was not covered by tests
} else {
builder.queryTimeoutMillis(queryTimeoutMillis);
}
Expand Down

0 comments on commit 9e86a58

Please sign in to comment.