Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update label for NestedFrame in html repr #64

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Update label for NestedFrame in html repr #64

merged 2 commits into from
Oct 17, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Oct 17, 2024 •
edited
Loading

Resolves #55

The result of this PR is the following:
Screen Shot 2024-10-17 at 1 42 38 PM

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Before [c8a18dd] After [135fc31] Ratio Benchmark (Parameter)
255±2ms 256±2ms 1 benchmarks.NestedFrameAddNested.time_run
261±3ms 262±3ms 1 benchmarks.NestedFrameReduce.time_run
535±4ms 526±4ms 0.98 benchmarks.NestedFrameQuery.time_run
157M 151M 0.96 benchmarks.NestedFrameAddNested.peakmem_run
158M 152M 0.96 benchmarks.NestedFrameQuery.peakmem_run
156M 149M 0.96 benchmarks.NestedFrameReduce.peakmem_run

Click here to view all benchmarks.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dougbrn dougbrn requested a review from hombit October 17, 2024 20:43
hombit
hombit approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dougbrn dougbrn merged commit d47d3a5 into main Oct 17, 2024
7 checks passed
@dougbrn dougbrn deleted the html_struct_rename branch October 17, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hombit hombit hombit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update NestedFrame display name
2 participants
@dougbrn @hombit