Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get and set interface #48

Merged
merged 1 commit into from
Aug 15, 2024
Merged

get and set interface #48

merged 1 commit into from
Aug 15, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Aug 15, 2024 •
edited
Loading

Change Description

Resolves #47.

  • My PR includes a link to the issue that I am addressing

Solution Description

This is a mirror implementation (not a direct wrapping) of the get and set interface recently introduced to nested-pandas.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@github-actions GitHub Actions
Copy link

Before [cf73e3f] <v0.1.3> After [24adf5b] Ratio Benchmark (Parameter)
453±1ms 458±3ms 1.01 benchmarks.NestedFrameQuery.time_run
154M 154M 1 benchmarks.NestedFrameQuery.peakmem_run
151M 151M 1 benchmarks.NestedFrameReduce.peakmem_run
218±1ms 219±2ms 1 benchmarks.NestedFrameReduce.time_run
155M 153M 0.99 benchmarks.NestedFrameAddNested.peakmem_run
216±2ms 213±0.8ms 0.99 benchmarks.NestedFrameAddNested.time_run

Click here to view all benchmarks.

@dougbrn dougbrn requested a review from wilsonbb August 15, 2024 21:31
wilsonbb
wilsonbb approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougbrn dougbrn merged commit 24fb348 into main Aug 15, 2024
8 checks passed
@dougbrn dougbrn deleted the get_set_interface branch August 15, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonbb wilsonbb wilsonbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap get and set interface
2 participants
@dougbrn @wilsonbb