Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test Failures from Numpy v2.0 #39

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Fix Test Failures from Numpy v2.0 #39

merged 5 commits into from
Jul 1, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Jul 1, 2024

Resolves #32.

This PR resolves some weird github-unique test errors that were reported in #32. The accessor tests were having seed issues with the conftests. This PR changes those failed tests to directly use the generate_data functions to to generate their seeded data. The generate_data test was also updated with a few seed stability checks. We may want to transition fully away from the conftest tests in favor of generate_data, but it seems to still work for the other tests at the moment.

Copy link

github-actions bot commented Jul 1, 2024

Before [0f4963e] After [9b8f059] Ratio Benchmark (Parameter)
148M 148M 1 benchmarks.NestedFrameAddNested.peakmem_run
149M 149M 1 benchmarks.NestedFrameQuery.peakmem_run
488±1ms 488±6ms 1 benchmarks.NestedFrameQuery.time_run
146M 146M 1 benchmarks.NestedFrameReduce.peakmem_run
230±0.9ms 229±2ms 1 benchmarks.NestedFrameReduce.time_run
228±2ms 224±2ms 0.98 benchmarks.NestedFrameAddNested.time_run

Click here to view all benchmarks.

@dougbrn dougbrn changed the title WIP: Fix Numpy 2 Failures Fix Test Failures from Numpy v2.0 Jul 1, 2024
@dougbrn dougbrn requested a review from hombit July 1, 2024 18:08
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it!

@dougbrn dougbrn merged commit f7626ff into main Jul 1, 2024
8 checks passed
@dougbrn dougbrn deleted the fix_numpy2_fails branch July 1, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoke test failure
2 participants