Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Base for error/debug/contracts cleanup #208

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] Base for error/debug/contracts cleanup #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
342f5c2
Base for error/debug/contracts cleanup
Breush May 3, 2019
1921976
Reverted some error cleanup changes
Breush May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion interfaces/driver/lb-utilities.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
/**************************************
* definition of LinBox's exceptions *
**************************************/
typedef LinBox::LinboxError lb_runtime_error;
typedef LinBox::Error lb_runtime_error;



Expand Down
1 change: 1 addition & 0 deletions linbox/algorithms/rational-cra-builder-early-single.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ namespace LinBox

Integer& result(Integer& d)
{
// @fixme Consider a better error object
throw "not a good idea calling this function here !!" ;
}
protected:
Expand Down
3 changes: 2 additions & 1 deletion linbox/matrix/densematrix/blas-matrix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,8 @@ namespace LinBox
/*! @internal
* Get read-only pointer to the matrix data.
*/
pointer getPointer() const ;
pointer getPointer() ;
const_pointer getPointer() const ;

const_pointer &getConstPointer() const ;

Expand Down
10 changes: 0 additions & 10 deletions linbox/matrix/sparse-formats.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,6 @@
#include "linbox/linbox-tags.h"

namespace LinBox {

/** Exception class for invalid matrix input
*/
namespace Exceptions {
class InvalidMatrixInput {};
}




//! Sparse matrix format (memory storage)
namespace SparseMatrixFormat {
class ANY {} ;
Expand Down
Loading