-
Notifications
You must be signed in to change notification settings - Fork 23
Linbox Developer Day 1
Clément Pernet edited this page Apr 1, 2017
·
3 revisions
- The github group for LinBox ecosystem: https://github.com/linbox-team
- Live discussion channel on slack: https://linbox.slack.com/ use preferably the channel #devday1
Since about a year, we experiment a new development model for the fflas-ffpack library: using the feature branch workflow. (see
- https://github.com/linbox-team/fflas-ffpack/wiki/Developer-resources
- https://www.atlassian.com/git/tutorials/comparing-workflows/feature-branch-workflow ).
In brief this means that
- commits to master branch are limited to trivial fixes (typos or on liner bug fixes)
- each new piece of code (bug fix or feature) needs to be developped in a new branch
- Once the branch is ready, create a pull request for it: thus inviting other developpers to review the branch
The review process include
- testing the branch on the reviewers machine,
- reading the diff of the code
- checking the continuous integration build status
Once everything is ok, the reviewer clicks on the "merge" button, hence merging the branch to master
- In order to avoid bottlenecks of PRs not being reviewed, we proposed that the author of a PR could himself merge it after and embargo period of a week or two. But ideally it should not be used. This framework is currently only implemented in fflas-ffpack for the moment. Feel free to use it in Givaro and LinBox too!
- giorgi: fflas-ffpack #67 Modular fails in DEBUG mode
- giorgi: fflas-ffpack #29 ftrsm with Modular (ftrsm_mp), consistently fails with small modulus (related to #27)
- lebreton + bruno: [givaro #10](https://github.com/linbox-team/givaro/issues/10]: Harmonization in Modular...<...> (maxCardinality bounds, Compute_t, ... )
- cdelaplace: debug of the spasm version of Linbox (sorry I have a bug with my user colour)
- jgd: merged fflas-ffpack PR #79: (faster triangular system solve with vector ftrsv)
- jgd: closed givaro #26
- jgd: closed linbox #40
- cpernet : closed givaro #40 "fails to select optimization flags on OSX" -> cannot reproduce
- jgd: fflas-ffpack #3 Create an example directory ---> Ok created a tutorial directory with 2x2 like things.
- jgd: fflas-ffpack other fast ftrsv missing
- cpernet: fix fflas-ffpack #77 -> PR #87: final fast ftrsv merged
- cpernet : merged FFLAS-FFPACK PR #73: (checkers for the determinant)
- cpernet: fix fflas-ffpack #84 test-suite for ftrmm -> PR #86
- jgd: merged PR #86: test suite for ftrmm merged
- dlucas : first fix to fflas-ffpack #80 about documentation improvement -> PR #88
- romain+bruno: First pass at Givaro Modular generic implemetation (issue Givaro #10) > branch GivaroHarmonizationModular
- cpernet: fix fflas-ffpack #85 ftrmv -> PR #89