Remove CONFIG_JTAG_ENABLE from Rpi3 build #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2017 01:40
… pins by setting the enable_jtag_gpio flag in config.txt
This was referenced Jun 29, 2017
jogarock
changed the title
|
@jogarock thanks for looking into this. I'd be more than happy to get rid of this. But to me it sounds like with your changes, we are more or less reverting this back to vanilla u-boot code? If that is the case, then I think it's even better to update our rpi3.xml files to point to the upstream u-boot instead. We prefer using upstream trees when possible. What do you think? @jforissier , regardless if we use upstream or decide to merge this, I think this should wait until after the 2.5.0 release. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Raspberry Pi 3 now allows one to enable JTAG on the Alt4 pins from the config.txt file. This should make it unnecessary to enable it by default in the U-boot build.
See the following Issue: OP-TEE/optee_os#1634
I'm also opening a PR in op-tee/build.