✨ Preview generation as a separate node instance #728
Conversation
shepilov
force-pushed
the
scale_preview_generation
branch
from
1f7bbca to
386bfaa
Compare
shepilov
changed the title
shepilov
force-pushed
the
scale_preview_generation
branch
from
708df34 to
cfe8a10
Compare
shepilov
force-pushed
the
scale_preview_generation
branch
from
cfe8a10 to
ee9cc12
Compare
shepilov
force-pushed
the
scale_preview_generation
branch
from
ee9cc12 to
2b2b64a
Compare
🐛 Fix config retrieval and type handling
shepilov
force-pushed
the
scale_preview_generation
branch
from
d1f6676 to
97d8c74
Compare
shepilov
force-pushed
the
scale_preview_generation
branch
from
97d8c74 to
66cb1db
Compare
ericlinagora
changed the title
| @@ -46,11 +46,11 @@ jobs: | |||
| - name: Prettier code style check | |||
| run: | | |||
| cd tdrive | |||
| docker compose -f docker-compose.tests.yml run -e NODE_OPTIONS=--unhandled-rejections=warn node npm run lint:prettier | |||
| docker compose -f docker-compose.dev.deps.yml -f docker-compose.tests.yml run -e NODE_OPTIONS=--unhandled-rejections=warn node npm run lint:prettier | |||
There was a problem hiding this comment.
maybe this is the opportunity to update the instructions in the README.md
There was a problem hiding this comment.
mmm, you are talking about the main readme file or some page in the documentation?
if main readme, I didn't get how it is connected
There was a problem hiding this comment.
Yeah the main /README.md, the instructions to start drive are outdated there, and we're changing them here... Had a couple of potential contributors get stuck on this
| healthcheck: | ||
| test: echo 'db.runCommand("ping").ok' | mongosh localhost:27017/test --quiet | ||
| networks: | ||
| - tdrive_network |
There was a problem hiding this comment.
healthcheck:
test: echo 'db.runCommand("ping").ok' | mongosh localhost:27017/test --quiet
| environment: | ||
| - REDIS_REPLICATION_MODE=master | ||
| networks: | ||
| - tdrive_network |
There was a problem hiding this comment.
healthcheck:
test: [ "CMD", "redis-cli", "--raw", "incr", "ping" ]| ports: | ||
| - 3310:3310 | ||
| networks: | ||
| - tdrive_network |
There was a problem hiding this comment.
current platform fails startup if clamav isn't ready, and in my tests, clamav opens the port long before it's ready, you actually have to wait for the reponse to be PONG (it responds "" for some time before it's ready). I use this in devenv, not entirely sure about docker compose command syntax for multiline https://github.com/ericlinagora/twake-drive-devenv/blob/master/devenv.nix#L604
| ports: | ||
| - "5432:5432" | ||
| networks: | ||
| - tdrive_network |
There was a problem hiding this comment.
healthcheck:
test: ["CMD-SHELL", "pg_isready"]There was a problem hiding this comment.
(these all come with changing the depends_on too to condition: service_healthy)
No description provided.