Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong file expiration date in mySpace #946

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fixed wrong file expiration date in mySpace #946

merged 2 commits into from
Feb 28, 2024

Conversation

KhaledNjim
Copy link
Collaborator

Description

GitLab issue

Root cause

Wrong Key for expiration date in document_details
The expiration date doesn't take into consideration undefined expiration date

Solution

Called the right expiration date key in document_details
Added handling for null expiration_date

@hoangdat hoangdat merged commit f55f0c6 into master Feb 28, 2024
4 checks passed
@hoangdat hoangdat deleted the bugFix/incorrect_file_expiration_date branch February 28, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KhaledNjim @hoangdat