Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inconsistent error in limactl create command when instance name and template is specified #3120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix inconsistent error in limactl create command when instance name and template is specified #3120

wants to merge 1 commit into from
+23 −22

Conversation

olamilekan000
Copy link
Contributor

@olamilekan000 olamilekan000 commented Jan 16, 2025 •
edited
Loading 

Change fixes inconsistency in the limactl create command when attempting to create an 
instance with an already existing name, when a template is specified and when it isn't.

Fixes #2575

@olamilekan000 olamilekan000 force-pushed the fix-inconsistency-in-limacttl-create-command-if-name-already-exists branch from 31107d6 to 0b3c6cb Compare January 16, 2025 18:13
@olamilekan000 olamilekan000 changed the title fix inconsistency error in limactl create command instance name exists fix inconsistent error in limactl create command instance name exists Jan 16, 2025
@olamilekan000 olamilekan000 changed the title fix inconsistent error in limactl create command instance name exists fix inconsistent error in limactl create command when instance name and template is specified Jan 16, 2025
@olamilekan000
Copy link
Contributor Author

@AkihiroSuda can you kindly review? Thanks

AkihiroSuda
AkihiroSuda reviewed Jan 17, 2025
View reviewed changes
cmd/limactl/start.go Outdated Show resolved Hide resolved
@olamilekan000 olamilekan000 force-pushed the fix-inconsistency-in-limacttl-create-command-if-name-already-exists branch from 0b3c6cb to d58e3ed Compare January 17, 2025 08:38
@olamilekan000 olamilekan000 force-pushed the fix-inconsistency-in-limacttl-create-command-if-name-already-exists branch from d58e3ed to d6a6d7f Compare January 17, 2025 08:40
AkihiroSuda
AkihiroSuda approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v1.1.0 (tentative) milestone Jan 17, 2025
@AkihiroSuda AkihiroSuda added the area/cli limactl CLI user experience label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/cli limactl CLI user experience
Projects
None yet
Milestone
v1.1.0 (tentative)
2 participants
@olamilekan000 @AkihiroSuda