Validate the jsonschema against default.yaml #2769
Open
+57
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders F Björklund <[email protected]>
AkihiroSuda
reviewed
Oct 20, 2024
| "github.com/invopop/jsonschema" | ||
| "github.com/lima-vm/lima/pkg/limayaml" | ||
| jsonschema2 "github.com/santhosh-tekuri/jsonschema/v6" |
There was a problem hiding this comment.
Would it be possible to avoid importing two jsonschema libs
There was a problem hiding this comment.
One is for generating, one is for validating. Their naming is unfortunate.
There was a problem hiding this comment.
Their import names could be better than "1" and "2" though.
Perhaps if it was put in two different files, as helper functions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to use the external location of the schema*, and prefer to not use the external python tool.
* that doesn't even exist yet https://www.schemastore.org/json/
https://pypi.org/project/check-jsonschema/
check-jsonschemaSo make it possible for the generator to validate that the generated schema matches the
default.yaml.Closes #2768