Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: create separate artifacts for macos-{13,14,15} #2762

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Oct 18, 2024

Now the following artifacts are created:

  • lima-VERSION-Darwin_macOS13-{arm64,x86_64}.tar.gz
  • lima-VERSION-Darwin_macOS14-{arm64,x86_64}.tar.gz
  • lima-VERSION-Darwin_macOS15-{arm64,x86_64}.tar.gz
  • lima-VERSION-Darwin-{arm64,x86_64}.tar.gz (identical to *-Darwin_macOS15-*)
  • lima-VERSION-Linux-{aarch64,x86_64}.tar.gz

Fix #2753

@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Oct 18, 2024
@AkihiroSuda AkihiroSuda force-pushed the fix-2753 branch 2 times, most recently from f54eb3b to 78c63ef Compare October 18, 2024 08:36
@AkihiroSuda

This comment was marked as resolved.

Now the following artifacts are created:
- lima-VERSION-Darwin_macOS13-{arm64,x86_64}.tar.gz
- lima-VERSION-Darwin_macOS14-{arm64,x86_64}.tar.gz
- lima-VERSION-Darwin_macOS15-{arm64,x86_64}.tar.gz
- lima-VERSION-Darwin-{arm64,x86_64}.tar.gz (identical to `*-Darwin_macOS15-*`)
- lima-VERSION-Linux-{aarch64,x86_64}.tar.gz

Fix issue 2753

Signed-off-by: Akihiro Suda <[email protected]>
@jandubois
Copy link
Member

jandubois commented Oct 18, 2024

lima-cdbdb72-Darwin-arm64.tar.gz
lima-cdbdb72-Darwin-x86_64.tar.gz
lima-cdbdb72-Darwin_macOS13-arm64.tar.gz
[...]
lima-cdbdb72-Darwin_macOS15-x86_64.tar.gz

Don't really like mixing _ and - in the filename. How about

lima-cdbdb72-Darwin-arm64-macos13.tar.gz
lima-cdbdb72-Darwin-arm64-macos14.tar.gz
lima-cdbdb72-Darwin-arm64-macos15.tar.gz
lima-cdbdb72-Darwin-arm64.tar.gz
lima-cdbdb72-Darwin-x86_64-macos13.tar.gz
lima-cdbdb72-Darwin-x86_64-macos14.tar.gz
lima-cdbdb72-Darwin-x86_64-macos15.tar.gz
lima-cdbdb72-Darwin-x86_64.tar.gz

@AkihiroSuda
Copy link
Member Author

lima-cdbdb72-Darwin-arm64.tar.gz
lima-cdbdb72-Darwin-x86_64.tar.gz
lima-cdbdb72-Darwin_macOS13-arm64.tar.gz
[...]
lima-cdbdb72-Darwin_macOS15-x86_64.tar.gz

Don't really like mixing _ and - in the filename. How about

lima-cdbdb72-Darwin-arm64-macos13.tar.gz
lima-cdbdb72-Darwin-arm64-macos14.tar.gz
lima-cdbdb72-Darwin-arm64-macos15.tar.gz
lima-cdbdb72-Darwin-arm64.tar.gz
lima-cdbdb72-Darwin-x86_64-macos13.tar.gz
lima-cdbdb72-Darwin-x86_64-macos14.tar.gz
lima-cdbdb72-Darwin-x86_64-macos15.tar.gz
lima-cdbdb72-Darwin-x86_64.tar.gz

I considered this, but I don't like splitting the OS identifier to two and put the arch name between them

@AkihiroSuda
Copy link
Member Author

Alternatively we can have

lima-cdbdb72-macOS-x86_64.tar.gz
lima-cdbdb72-macOS13-arm64.tar.gz
...

But this will probably break somebody's script

@jandubois
Copy link
Member

I considered this, but I don't like splitting the OS identifier to two and put the arch name between them

I know, but it is the only way to keep all the releases for each arch together.

@jandubois
Copy link
Member

Anyways, looks like every possible naming scheme has some drawbacks, so we just have to pick one. If you prefer the one with the -, then let's keep it as-is.

@AkihiroSuda
Copy link
Member Author

Don't really like mixing _ and - in the filename.

We already have an underscore in "x86_64", so I think this is fine?

@jandubois
Copy link
Member

We already have an underscore in "x86_64", so I think this is fine?

I'm not saying it is fine, but I won't object. 😄

We do seem to have a CI issue though:

CleanShot 2024-10-18 at 10 20 32@2x

@AkihiroSuda
Copy link
Member Author

We do seem to have a CI issue though:

This is because "Release / Artifacts Darwin" was split to "Release / Artifacts Darwin (macos-15)" etc.

Removed the corresponding rule from https://github.com/lima-vm/lima/settings/branches.

@AkihiroSuda AkihiroSuda requested a review from a team October 18, 2024 22:11
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit 121b728 into lima-vm:master Oct 18, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants