Refactor update-template-ubuntu.sh and add update-template-debian.sh
#2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
norio-nomura
force-pushed
the
update-template-debian.sh
branch
from
153a6e2
to
8b2133d
Compare
… within 10 minutes Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
…ring Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
…ead of tsv Since `unpacked/SHA256SUMS` has no `Content-Type`, the output of `curl -w` formatted as TSV causes `IFS=$'\t' read -r` to fail during parsing. Signed-off-by: Norio Nomura <[email protected]>
…o use cache Signed-off-by: Norio Nomura <[email protected]>
…lavor_version` Signed-off-by: Norio Nomura <[email protected]>
…info` that returns the image entry with the kernel info instead of returning the kernel info. Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
Functions in this script assume error handling with 'set -e'. To ensure 'set -e' works correctly: - Use 'set +e' before assignments and '$(set -e; <function>)' to capture output without exiting on errors. - Avoid calling functions directly in conditions to prevent disabling 'set -e'. - Use 'shopt -s inherit_errexit' (Bash 4.4+) to avoid repeated 'set -e' in all '$(...)'. Changes: - Add `error_exit` and more error messages - Remove `|| return` after `$(...)` - Use `jq -e` Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
…e adding `.kernel.cmdline` Signed-off-by: Norio Nomura <[email protected]>
…ud:released:download.json` does not contain a matching image Signed-off-by: Norio Nomura <[email protected]>
…nel location is not null Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
…tributions - Move functions common to all distributions here. - Scripts for specific distributions accept distribution-specific options and perform additional actions. Signed-off-by: Norio Nomura <[email protected]>
norio-nomura
force-pushed
the
update-template-debian.sh
branch
from
8b2133d
to
2af6bcd
Compare
|
Finally, I've laid the groundwork to add code for other distributions. Now, I'll start adding code for Debian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update-template-ubuntu.shto separate distribution-specific code.update-template.sh.update-template-debian.shto handle Debian.This PR aims to add Debian support as per #1347.
Also fixes: #2756