templates: merge experimental/{riscv64,armv7l} into default
#2730
Conversation
| logrus.Warn("template://experimental/riscv64 was merged into the default template in Lima v1.0. Use `limactl create --arch=riscv64 template://default` instead.") | ||
| case "experimental/armv7l": | ||
| logrus.Warn("template://experimental/armv7l was merged into the default template in Lima v1.0. Use `limactl create --arch=armv7l template://default` instead.") | ||
| } |
There was a problem hiding this comment.
I'll also remove experimental/{9p,virtiofs-linux,vz} in favor of the limactl CLI flags, in a separate PR
examples/default.yaml
Outdated
| @@ -20,7 +20,7 @@ vmOpts: | |||
| qemu: | |||
| # Minimum version of QEMU required to create an instance of this template. | |||
| # Will be ignored if the vmType is not "qemu" | |||
| # 🟢 Builtin default: not set | |||
| # 🟢 Builtin default: not set (but RISC-V requires QEMU 9.1 or later) | |||
| minimumVersion: null | |||
There was a problem hiding this comment.
Maybe minimumVersion should be typed as map[Arch] bool? (in a separate PR)
There was a problem hiding this comment.
(Anyway riscv64 is experimental; I don't want to spend too much time for overengineering it)
There was a problem hiding this comment.
I think it worked on earlier versions as well, as long as you supplied the firmware and kernel?
Maybe the qemu implementation details can stay out of the default configuration comments.
There was a problem hiding this comment.
I think it worked on earlier versions as well, as long as you supplied the firmware and kernel?
Yes, but s/and/or/
Maybe the qemu implementation details can stay out of the default configuration comments.
Done
These archs still remain experimental but can be merged into the `default` template. `.containerd.user` now defaults to `false` for these archs, as `nerdctl-full` archive is still missing for them. Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
unify-riscv64-template
branch
from
5c6cfda
to
dd04a85
Compare
These archs still remain experimental but can be merged into the
defaulttemplate..containerd.usernow defaults tofalsefor these archs, asnerdctl-fullarchive is still missing for them.