-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register burnables properly on fabric #81
base: 1.19
Are you sure you want to change the base?
Conversation
Fix lilypuree#76 This also creates a <wood_item>s_that_burn tag for each wood item and use that for registration, so that warped and crimson ones don't burn (like all their wooden items in vanilla)
@lilypuree do you have some time to look over this PR please? It fixes the quilt incompatibility |
Implementing this quick fix would be much appreciated. I'd build the fixed version myself but am dumb with computers and have a step fail every time :( |
@lilypuree please could you do this as my quilt modpack REALLY needs this mod |
Bump |
bump |
|
are you sure? did you test it? it's been a while but i think i remember it working perfectly. i'm assuming what's happening is it's registering the tag itself, and it's looked up in-world when needed |
Nvm, it seems like Fabric Api handles that case by clearing caches every time tags are loaded. |
@Fuzss Looks like TheWinABagel's fork only adds the relevant block tags, not item tags. (TheWinABagel@e13290b#diff-f1afe8d18a5d2cf47951c181edce2c948583348d3ec780f1841fc9d8b1111af3) |
Whoops, will fix and upload a new version. I really need to figure out git one of these days... |
Fix #76
This also creates a <wood_item>s_that_burn tag for each wood item and use that for registration, so that warped and crimson ones don't burn (like all their wooden items in vanilla)