Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md #80

Closed
wants to merge 1 commit into from
Closed

Update readme.md #80

wants to merge 1 commit into from

Conversation

crftbt
Copy link
Contributor

@crftbt crftbt commented Apr 21, 2024

Adding full path for people like me who didn't know where this goes without asking others. :)

Adding full path for people like me who didn't know where this goes without asking others. :)
@lilyinstarlight
Copy link
Owner

This is probably good info. We should include more about flake gotchas like how it will no longer use your system channels (and nixos-rebuild --upgrade won't upgrade anything anymore), but that can done in a follow-up

I'm on mobile and just woke up, but I'll try to do a proper review and merge on these PRs sometime today!

Copy link
Owner

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this should clarify this better for non-flakes users?

@@ -6,7 +6,7 @@ Nix package set and NixOS module for using COSMIC from NixOS. This is a temporar

### Flakes

If you have an existing `configuration.nix`, you can use the `nixos-cosmic` flake with the following:
If you have an existing `configuration.nix`, you can use the `nixos-cosmic` flake by adding the following to /etc/nixos/flake.nix:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you have an existing `configuration.nix`, you can use the `nixos-cosmic` flake by adding the following to /etc/nixos/flake.nix:
If you have an existing `configuration.nix`, you can use the `nixos-cosmic` flake with the following in an adjacent `flake.nix`:
**Note:** If switching from traditional evaluation to flakes, `nix-channel` will no longer have any effect on the nixpkgs your system is built with, and therefore `nixos-rebuild --upgrade` will also no longer have any effect. You will need to use `nix flake update` from your flake directory to update nixpkgs and nixos-cosmic.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this suggestion acceptable? If so, I'll commit it to this branch and then merge this PR

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone ahead and applied this suggestion. If it's sufficient feel free to close this PR and if not, let me know and we can come up with something that works for you :)

@lilyinstarlight lilyinstarlight linked an issue May 8, 2024 that may be closed by this pull request
@lilyinstarlight
Copy link
Owner

Closing since this should be resolved now. Feel free to open a new PR if you found anything else unclear, contributions are of course very appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

readme.md code
2 participants