Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic-ext-applet-external-monitor-brightness: init at unstable-2024-07-04 #412

Merged

Conversation

colemickens
Copy link
Contributor

Hi,

This is a WIP since the postPatch step fails, the ./target/release is handled differently in the justfile and I haven't fixed it yet.

(Advice or patches welcome)

I mostly want this for the quick dark mode toggle.

Copy link
Owner

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@colemickens
Copy link
Contributor Author

Thanks @lilyinstarlight. This is building and initial testing looks like it works!

@colemickens colemickens changed the title WIP: cosmic-ext-applet-external-monitor-brightness: init at unstable-2024-07-04 cosmic-ext-applet-external-monitor-brightness: init at unstable-2024-07-04 Oct 13, 2024
@colemickens colemickens marked this pull request as ready for review October 13, 2024 16:32
Copy link
Owner

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more comments, thanks again! <3

@lilyinstarlight
Copy link
Owner

Oh also if you are willing (but no big deal if not), push a second commit adding it to environment.systemPackages in the VM output of the flake, for testing

@colemickens colemickens force-pushed the colemickens/ext-mon-bright branch 3 times, most recently from 06b79f2 to e321f8a Compare October 15, 2024 18:35
Copy link
Owner

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit and with this and the prior two comments, this looks ready to go :)

@lilyinstarlight lilyinstarlight enabled auto-merge (rebase) October 16, 2024 17:10
@lilyinstarlight lilyinstarlight merged commit 8181909 into lilyinstarlight:main Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants