Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD THE MORSE CODE MAP AND DECODER #1

Merged
merged 3 commits into from
Nov 3, 2023
Merged

ADD THE MORSE CODE MAP AND DECODER #1

merged 3 commits into from
Nov 3, 2023

Conversation

Ochiengsteven
Copy link
Collaborator

🔤 Feature Implementation: Morse Code Decoder Methods

This pull request contains the implementation of Morse code decoding methods. The implemented methods translate Morse code into string representations of characters, words, and entire messages.

Implemented Morse Code Decoding Methods:

  1. decode_char method: Decodes a Morse code character into the corresponding uppercase character.

    • Example: decode_char(".-") returns "A".
  2. decode_word method: Decodes an entire word in Morse code, returning the string representation.

    • Example: decode_word("-- -.--") returns "MY".
  3. decode method: Decodes the entire message in Morse code, providing the string representation.

    • Example: decode("-- -.-- -. .- -- .") returns "MY NAME".

Key Implementation Details:

  • Emphasized code reusability to ensure a Don't Repeat Yourself (DRY) approach.
  • Utilized separate methods for decoding characters, words, and entire messages.

Morse Code Message Decoding:

Applied the implemented methods to decode the Morse code message from the provided example:

.- -... --- -..- ..-. ..- .-.. .-.. --- ..-. .-. ..- -... .. . ...

Copy link

@1GORDON 1GORDON left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: APPROVED 🟢

Hi @Ochiengsteven, and @lily4178993

Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉 👏 👏 💯

Highlights!

  • Has #decode_char method ✔️
  • Has #decode_word method and works as expected ✔️
  • Has #decode method and works as expected ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend considering them as they can improve your code.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread and tag me @1GORDON if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, request a second opinion using this form.

@lily4178993
Copy link
Owner

Thank you @1GORDON for your review and feedback.

@lily4178993 lily4178993 merged commit 06aa9df into dev Nov 3, 2023
1 check passed
Repository owner locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants