Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version of dendrogram #295

Merged
merged 3 commits into from
May 3, 2024
Merged

New version of dendrogram #295

merged 3 commits into from
May 3, 2024

Conversation

yihming
Copy link
Member

@yihming yihming commented May 1, 2024 •
edited
Loading

  • Use Connection Specific Index (CSI) for the distance calculation;
  • Split into 2 functions:
    • calc_dendrogram to calculate linkage, then store in data.uns;
    • plot_dendrogram to plot a dendrogram based on the linkage calculated.

bli25
bli25 requested changes May 2, 2024
View reviewed changes
Copy link
Member

@bli25 bli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the minor comment and feel free to merge!

pegasus/plotting/plot_library.py Outdated Show resolved Hide resolved
@yihming yihming merged commit 77629e2 into master May 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bli25 bli25 bli25 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihming @bli25