Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add classless stylesheet #162

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benharri
Copy link
Contributor

just a thought, i played with this while testing #161 and it felt pretty nice

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atproto-browser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:19am
frontpage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:19am
unravel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:19am

Copy link

vercel bot commented Oct 24, 2024

@benharri is attempting to deploy a commit to the Scribe Team on Vercel.

A member of the Team first needs to authorize it.

@damiensedgwick
Copy link
Contributor

Thanks for this Ben!

I don't want to speak for the rest of the team but I believe we are all pretty happy with the look and feel of frontpage using Shad / our current theming.

Leaving the pull request open for now to give the others a chance to consider it but more than anything, just wanted to say thanks for contributing to Frontpage and making it awesome!

@tom-sherman
Copy link
Contributor

@damiensedgwick this is not for Frontpage 😅

@damiensedgwick
Copy link
Contributor

damiensedgwick commented Oct 24, 2024

@damiensedgwick this is not for Frontpage 😅

I was just making sure the rest of you are paying attention!

(Read as, I got confused due to the rename and 'frontpage' being mentioned in the notifications)

@benharri ignore me, I had not yet drank my coffee beans!

Copy link
Contributor

@timothyis timothyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I would say that it needs some further changes because it allows for darkmode and the contrast does not look good in places where the styles were intended only for lightmode. For example, darkgreen on the dark background:
image

@benharri
Copy link
Contributor Author

oh yeah that contrast isn't great - i'll play with some of the colors a bit

in general yall are ok with adding this kind of classless styles to atprotobrowser though right?

@tom-sherman
Copy link
Contributor

@benharri yep I like the semantics-based CSS framework approach but I'd like the design to stay minimalist and barebones looking.

I'm also a bit concerned about checking in a minified CSS file though, where is this from? I assume it's a semantic CSS framework like picocss? If we can find something that keeps it looking retro/minimalist that's also eg. installable from npm that'd be ideal

@benharri
Copy link
Contributor Author

good call, i will switch it to npm installed. the minified css is the dist from https://watercss.kognise.dev/

@benharri
Copy link
Contributor Author

it's now picocss from npm and i added the main.container for the styles to apply along with grouping the aturi form with a fieldset

@benharri
Copy link
Contributor Author

good call on pico, it's a bit cleaner

@benharri benharri changed the title add water.css styles add classless stylesheet Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants