-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add classless stylesheet #162
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@benharri is attempting to deploy a commit to the Scribe Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for this Ben! I don't want to speak for the rest of the team but I believe we are all pretty happy with the look and feel of frontpage using Shad / our current theming. Leaving the pull request open for now to give the others a chance to consider it but more than anything, just wanted to say thanks for contributing to Frontpage and making it awesome! |
@damiensedgwick this is not for Frontpage 😅 |
I was just making sure the rest of you are paying attention! (Read as, I got confused due to the rename and 'frontpage' being mentioned in the notifications) @benharri ignore me, I had not yet drank my coffee beans! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah that contrast isn't great - i'll play with some of the colors a bit in general yall are ok with adding this kind of classless styles to atprotobrowser though right? |
@benharri yep I like the semantics-based CSS framework approach but I'd like the design to stay minimalist and barebones looking. I'm also a bit concerned about checking in a minified CSS file though, where is this from? I assume it's a semantic CSS framework like picocss? If we can find something that keeps it looking retro/minimalist that's also eg. installable from npm that'd be ideal |
good call, i will switch it to npm installed. the minified css is the dist from https://watercss.kognise.dev/ |
it's now picocss from npm and i added the |
good call on pico, it's a bit cleaner |
just a thought, i played with this while testing #161 and it felt pretty nice