-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default path that assetic can handle #106
base: master
Are you sure you want to change the base?
Conversation
Why should we pointing the default paths to locations where assetic it can't handle? We should use views/ by default.
can you elaborate a bit what you mean? indeed its a known issue that assetic cannot pick up assets in all locations but I do not see what alternative we have |
Hi Ismith, you are right! At this moment there are no well known alternatives for this problem. But in the entire README.md we point to locations those are not compatible with assetic. For example in the top of the readme: In your bundle directory it will look under Resources/themes/ or fall back to the normal Resources/views if no matching file was found. Why don't we use Resources/views/themes/ as default path? I spend 4 hours to use paths like: App/Resources/views/themes/mytheme/MyBundle/Default/index.html.twig (this path is compatible with assetic and it's possible to bundle the templates in one location) I have to mention that one of the major time spending issue was the %app_path% with wrong explaination, anyway if we suggest default assetic compatible paths, a lot more people enjoying this wonderful bundle. What do you think? |
Hmm .. not sure why we never considered this (a long time ago we made this decision .. not sure if I am forgetting something) .. it feels a bit iffy to have the themes mixed in with the views but I guess one can also say its cleaner to have all templates in the same dir. that being said, this would be a BC break which would I guess mean a new major version .. |
btw for anyone wondering about what issue is being addressed here: |
is this fixed by https://github.com/liip/LiipThemeBundle#assetic-integration ? the above link no longer works. |
ping |
@thormeier / @dbu can you check this? |
Why should we pointing the default paths to locations where assetic it can't handle? We should use views/ by default.