handle image extensions in doctrine loader #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // try to find the image without extension | ||
| $info = pathinfo($path); | ||
| $name = $info['dirname'].'/'.$info['filename']; | ||
|
|
lsmith77
added a commit
that referenced
this pull request
Dec 4, 2013
handle image extensions in doctrine loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards #78 - we try to lookup an image also without file extension. this is more of a content negotiation thing than of proper ids, so @lsmith77 and i feel it belongs here rather than for example https://github.com/symfony-cmf/MediaBundle/blob/master/Doctrine/Phpcr/MediaManager.php#L121
with this change it will become possible to at least build your image urls with a hardcoded format, e.g. use
format: jpgin the filter definition, or put it into the output like{{ item.image.id | imagine_filter('header_desktop') }}.jpg/cc @rmsint