Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed url for file with new extension #211

Closed
wants to merge 2 commits into from
Closed

Fixed url for file with new extension #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2ccf74
Fixed url for file with new extension
vlastv Jul 25, 2013
b2e74a5
Fixed test for new name
vlastv Jul 25, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Imagine/Cache/CacheManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ public function generateUrl($path, $filter, $absolute = false)
$pathinfo['dirname'] = '';
}

$path = $pathinfo['dirname'].'/'.$pathinfo['filename'].'.'.$config['format'];
$path = $pathinfo['dirname'].'/'.$pathinfo['basename'].'.'.$config['format'];
}
}

Expand Down
2 changes: 1 addition & 1 deletion Tests/Imagine/Cache/CacheManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ public function generateUrlProvider()
// 'format' given, altering URL
array(array(
'format' => 'jpg',
), '/thumbnail/cats.jpeg', 'thumbnail/cats.jpg'),
), '/thumbnail/cats.jpeg', 'thumbnail/cats.jpeg.jpg'),

// No 'extension' path info
array(array(
Expand Down