Add support for Symfony 7 #1535
Conversation
| class WarmupCacheHandler implements MessageHandlerInterface | ||
| class WarmupCacheHandler |
There was a problem hiding this comment.
The interface is removed in favor of the AsMessageHandler attribute for autowiring, but since the service isn't autowired, the attribute isn't really necessary here.
| @@ -21,8 +21,6 @@ | |||
| use Symfony\Component\Mime\MimeTypes; | |||
|
|
|||
| /** | |||
| * @requires PHP 5.4 | |||
There was a problem hiding this comment.
Package requires PHP 7.2, so this is unnecessary
| @@ -21,8 +21,6 @@ | |||
| use Symfony\Component\Mime\MimeTypes; | |||
|
|
|||
| /** | |||
| * @requires PHP 7.2 | |||
There was a problem hiding this comment.
Package requires PHP 7.2, so this is unnecessary
| @@ -21,8 +21,6 @@ | |||
| use Symfony\Component\Routing\RequestContext; | |||
|
|
|||
| /** | |||
| * @requires PHP 7.2 | |||
There was a problem hiding this comment.
Package requires PHP 7.2, so this is unnecessary
| use Symfony\Component\Messenger\MessageBusInterface; | ||
|
|
||
| /** | ||
| * @requires PHP 7.1 |
There was a problem hiding this comment.
Package requires PHP 7.2, so this is unnecessary
| public function testShouldImplementMessageHandlerInterface(): void | ||
| { | ||
| $rc = new \ReflectionClass(WarmupCacheHandler::class); | ||
|
|
||
| $this->assertTrue($rc->implementsInterface(MessageHandlerInterface::class)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Since the interface is removed from the framework, and the class no longer implements it, the test is unnecessary.
| public static function setUpBeforeClass(): void | ||
| { | ||
| if (!class_exists(Helper::class)) { | ||
| static::markTestSkipped('Test requires deprecated symfony/templating component'); | ||
| } | ||
| } |
There was a problem hiding this comment.
symfony/templating is deprecated and removed from the framework in 7.0. So, this can't be tested when working with versions of the framework without the component are installed.
Just as the title says, adds support for Symfony 7