Allow PDF to be find #1122
Closed
Allow PDF to be find #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdevpl
reviewed
Dec 25, 2018
|
Hi @Seb33300 , |
|
can you please add a functional test in https://github.com/liip/LiipImagineBundle/blob/master/Tests/Functional/Controller/ImagineControllerTest.php so that we can be sure the response mime type corresponds to the output? |
This make possible to work with PDF files when using `imagick` driver.
|
I rebased my pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make possible to work with PDF files when using
imagickdriver.