updates per reviews from @dbu and @franmomu

liip · Nov 25, 2021 · ac371a7 · ac371a7
1 parent 58902a8
commit ac371a7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/Binary/Loader/ChainLoader.php b/src/Binary/Loader/ChainLoader.php
@@ -39,11 +39,11 @@ public function find($path)
     {
         $exceptions = [];
 
-        foreach ($this->loaders as $configName => $objectInst) {
+        foreach ($this->loaders as $configName => $loader) {
             try {
-                return $objectInst->find($path);
+                return $loader->find($path);
             } catch (NotLoadableException $loaderException) {
-                $exceptions[] = new ChainAttemptNotLoadableException($configName, $objectInst, $loaderException);
+                $exceptions[] = new ChainAttemptNotLoadableException($configName, $loader, $loaderException);
             }
         }
 

diff --git a/src/Exception/Binary/Loader/ChainAttemptNotLoadableException.php b/src/Exception/Binary/Loader/ChainAttemptNotLoadableException.php
@@ -13,15 +13,15 @@
 
 use Liip\ImagineBundle\Binary\Loader\LoaderInterface;
 
-class ChainAttemptNotLoadableException extends NotLoadableException
+final class ChainAttemptNotLoadableException extends NotLoadableException
 {
-    private string $configName;
-    private LoaderInterface $objectInst;
+    private string          $configName;
+    private LoaderInterface $loaderInst;
 
-    public function __construct(string $configName, LoaderInterface $objectInst, NotLoadableException $loaderException)
+    public function __construct(string $configName, LoaderInterface $loaderInst, NotLoadableException $loaderException)
     {
         $this->configName = $configName;
-        $this->objectInst = $objectInst;
+        $this->loaderInst = $loaderInst;
 
         parent::__construct($this->compileFailureText(), 0, $loaderException);
     }
@@ -33,7 +33,7 @@ public function getLoaderConfigName(): string
 
     public function getLoaderObjectInst(): LoaderInterface
     {
-        return $this->objectInst;
+        return $this->loaderInst;
     }
 
     public function getLoaderObjectName(): string

diff --git a/src/Exception/Binary/Loader/ChainNotLoadableException.php b/src/Exception/Binary/Loader/ChainNotLoadableException.php
@@ -11,7 +11,7 @@
 
 namespace Liip\ImagineBundle\Exception\Binary\Loader;
 
-class ChainNotLoadableException extends NotLoadableException
+final class ChainNotLoadableException extends NotLoadableException
 {
     public function __construct(string $path, ChainAttemptNotLoadableException ...$exceptions)
     {
@@ -39,8 +39,8 @@ private static function compileLoaderErrorsList(ChainAttemptNotLoadableException
         }, ...$exceptions);
     }
 
-    private static function implodeArrayMappedExceptions(\Closure $listMapper, ChainAttemptNotLoadableException ...$exceptions): string
+    private static function implodeArrayMappedExceptions(\Closure $mapper, ChainAttemptNotLoadableException ...$exceptions): string
     {
-        return implode(', ', array_map($listMapper, $exceptions));
+        return implode(', ', array_map($mapper, $exceptions));
     }
 }