Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin benches #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Kotlin benches #4

wants to merge 2 commits into from

Conversation

d-plaindoux
Copy link
Contributor

@d-plaindoux d-plaindoux commented Oct 17, 2022 •
edited
Loading

  • Math lib transpiration to Kotlin
  • Test done and correct
  • Benchmarks done
  • README and conclusion

@d-plaindoux d-plaindoux self-assigned this Oct 17, 2022
melwyn95
melwyn95 approved these changes Nov 3, 2022
View reviewed changes
bench/bench_kotlin/src/main/kotlin/math/Repr.kt

fun lte(a: t): (t) -> Boolean

fun gt(a: t): (t) -> Boolean = { b -> lt(b)(a) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about Kotlin, but seems like there is no support for currying, should this be written in un-curried style (tupled params lt(a, b)) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. And at the same time, I can check whether the inlining can be specified.

@melwyn95
Copy link
Contributor

melwyn95 commented Nov 3, 2022

Is it okay for bench/bench_kotlin/gradle/wrapper/gradle-wrapper.jar to be checked into git?

melwyn95
melwyn95 reviewed Nov 3, 2022
View reviewed changes
bench/bench_kotlin/src/main/kotlin/math/Trigo.kt
}
}

fun sinus(a: t, n: Int): t = sinus_symmetry(one, a, n)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't n be BigInteger ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melwyn95 melwyn95 melwyn95 approved these changes

Assignees

@d-plaindoux d-plaindoux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-plaindoux @melwyn95