Makefile updates #14
Open
Makefile updates #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use docker ligo by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm surprised that this project uses a Makefile, which does not strike me as being a standard tool in the Tezos ecosystem, but I don't particularly mind.
However, if the user does have
make, then they most likely have some basic configuration allowing command line-based development, and must have aligoexecutable or alias somewhere. I don't think this Makefile should assume that the user did not configure their environment, hence it should not, IMO, default to the Docker version.To my knowledge, it's also good practice to write environment variables in all caps, especially if we expect the user to change them.
I did not change the
protocol_opt?variable but I'm not sure it's supposed to be used at all.