-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poc: rpc prop tests #1083
Draft
jharveyb
wants to merge
5
commits into
main
Choose a base branch
from
rpc_prop_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
poc: rpc prop tests #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharveyb
force-pushed
the
rpc_prop_tests
branch
from
August 14, 2024 22:07
5f2682a
to
2d1bccb
Compare
Pull Request Test Coverage Report for Build 10426710362Details
💛 - Coveralls |
jharveyb
force-pushed
the
rpc_prop_tests
branch
from
August 16, 2024 21:52
2d1bccb
to
8b579da
Compare
I think this is in a decent state for now - this change to I'd prefer to block merging this until that PR (or something similar enough) lands in a The gRPC message generators could be moved elsewhere, but I imagine moving them to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts to address #1078 .
I think this logic can probably be simplified a fair amount wrt. reducing the # of switches. I think adding wrapper types with their own validity-checking functions would also help for that; handling proto enums makes the test a lot larger, but I think most of the REST endpoints will have enum fields to support arguments as strings.
Rapid has some functions to autogenerate values via reflection: https://pkg.go.dev/pgregory.net/rapid#Make
I'm not sure if that will populate the gRPC private fields like
state
,unknownFields
, etc. IIUC we don't want those to be populated.This small test found some missing checks, which would probably get rejected later on. Will peek at other RPCs with more fields to test out more complex invariants.