StaticAddr: Withdraw arbitrary amounts #860
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…address StaticAddr: withdrawal destination address and fee rate
hieblmi
commented
Dec 2, 2024
hieblmi
force-pushed
the
withdraw-amounts
branch
4 times, most recently
from
d69eda3
to
4f2ff5d
Compare
hieblmi
force-pushed
the
withdraw-amounts
branch
from
4f2ff5d
to
f7af7b4
Compare
starius
reviewed
Dec 3, 2024
| // The change amount will be sent back to the static address. The client | ||
| // ensures that the change amount covers the transaction fee, and that the | ||
| // change after fees is at least the dust limit. | ||
| int64 change_amount = 5; |
There was a problem hiding this comment.
I propose to replace client_withdrawal_addr, withdraw_amount and change_amount with a psbt, so the UTXO could be used for whatever purpose, e.g. batch sending, coinjoin/payjoin, channel opening etc.
| addressParams, err := m.cfg.AddressManager.GetStaticAddressParameters( | ||
| ctx, | ||
| // Send change back to the static address. | ||
| changeAddress, err := m.cfg.AddressManager.GetTaprootAddress( |
There was a problem hiding this comment.
Why m.cfg.AddressManager.GetStaticAddress(ctx) can't be used here?
hieblmi
force-pushed
the
static-addr-staging
branch
from
5b68e42
to
fb9562b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an amount field to the withdrawal rpc.
It allows to withdraw a fraction of the sum of selected deposits to withdraw. The change is sent back to the static address.
If the change is below the dust limit it goes towards miner fees, but warns the user beforehand.