Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minrelayfee func #200

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Minrelayfee func #200

merged 1 commit into from
Oct 30, 2024

Conversation

gijswijs
Copy link

@gijswijs gijswijs commented Oct 29, 2024

Added MinRelayFee func to walletkit_client.go.

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I though we could do this against the master branch, but it turns out the new field was actually only added in 0.18.x, so lnd-18-4 is the correct branch.

walletkit_client.go Outdated Show resolved Hide resolved
@gijswijs gijswijs force-pushed the minrelayfee branch 2 times, most recently from da11abd to 108aadd Compare October 29, 2024 20:40
@guggero
Copy link
Member

guggero commented Oct 30, 2024

Can you squash the commits? Then I think we can merge this. Or is anything else missing here? Just waiting to confirm everything works in tapd?

Added MinRelayFee func to walletkit_client.go.
@gijswijs gijswijs marked this pull request as ready for review October 30, 2024 17:14
@gijswijs
Copy link
Author

gijswijs commented Oct 30, 2024

Just waiting to confirm everything works in tapd?

Exactly. All seems to work. So we have a cascade of PRs depending on this one.

@guggero guggero merged commit 895a850 into lnd-18-4 Oct 30, 2024
1 check passed
@guggero guggero deleted the minrelayfee branch October 30, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants