Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new RPCs introduced in lnd v0.18.4 #192

Merged
merged 11 commits into from
Sep 27, 2024
Merged

Conversation

guggero
Copy link
Member

@guggero guggero commented Sep 18, 2024

Updates the client to expose all new RPCs added for the custom channel functionality with lnd 0.18.4-beta.

EDIT: Since part 4 was merged into master and the version of master bumped to v0.18.99-beta, we can now go ahead and merge this PR into the lnd-18-4 branch.

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

To avoid needing to wait a full 5 seconds to re-try checking lnd's
status, we allow passing in a custom poll interval.
This significantly speeds up some integration tests.
guggero and others added 5 commits September 20, 2024 13:09
With the latest lnd master versioned as v0.18.99-beta, we can now
require this commit of lndclient to require a minimum version of
v0.18.4-beta (which will ship all the RPC changes in this PR).
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@dstadulis dstadulis assigned ffranr and unassigned guggero Sep 26, 2024
@bhandras bhandras merged commit af0a846 into lnd-18-4 Sep 27, 2024
1 check passed
@bhandras bhandras deleted the update-to-lnd-18-4 branch September 27, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants